fix: handle DESCRIBE SELECT #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakalon
approved these changes
Sep 9, 2024
tests/conftest.py
Outdated
| @@ -77,6 +77,12 @@ async def query( | |||
| self.waiting.set() | |||
| await self.pause.wait() | |||
| self.waiting.clear() | |||
|
|
|||
| if isinstance(expression, exp.Describe): | |||
There was a problem hiding this comment.
Do we need this?
I'm not sure what the assert is doing below. It must be intended for the execute call.
xiaoyu-meng-mxy
commented
Sep 9, 2024
| # @pytest_asyncio.fixture | ||
| # async def query_fixture( | ||
| # mysql_connector_conn: MySQLConnection, | ||
| # mysql_connector_conn: MySQLConnectionAbstract, |
There was a problem hiding this comment.
We no longer use MySQLConnection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the below sentences from the mysql doc
"The DESCRIBE and EXPLAIN statements are synonyms."
"but the MySQL parser treats them as completely synonymous."
"EXPLAIN SELECT * FROM table" is equal to "DESCRIBE SELECT * FROM table" so we should not rewrite all the DESCRIBE statement to SHOW.
@barakalon